https://gitlab.synchro.net/main/sbbs/-/commit/ff1ebae7920c50df2855051c
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Add debug-level log messages when import_netmail() returns a non-zero value

To help debug any situations where import_netmail() might silently fail
(though I don't anticipate there are any, Accession suggested there was).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Why are these being posted? Curious

--- Steve K9ZW via SPOT BBS

--- Mystic BBS v1.12 A49 2024/05/29 (Raspberry Pi/32)
* Origin: SPOT BBS / k9zw (1:154/154)
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: Re: src/sbbs3/sbbsecho.c
By: k9zw to Rob Swindell (on Windows 11) on Tue Feb 04 2025 06:54 am

Why are these being posted? Curious

This is the "Synchronet Programming (C/C++ and Git)" Conference, so the source code repository activity (changes to the Synchronet source, primarily) get posted here, so sysop can see what's changing (fixes, new features, etc.).
--
digital man (rob)

This Is Spinal Tap quote #5:
Nigel Tufnel: Authorities said... best leave it... unsolved.
Norco, CA WX: 55.6øF, 78.0% humidity, 0 mph ENE wind, 0.00 inches rain/24hrs ---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

On 04 Feb 2025, Digital Man said the following...

Re: Re: src/sbbs3/sbbsecho.c
By: k9zw to Rob Swindell (on Windows 11) on Tue Feb 04 2025 06:54 am

Why are these being posted? Curious

This is the "Synchronet Programming (C/C++ and Git)" Conference, so the source code repository activity (changes to the Synchronet source,

Alas my system merged this in another echo... puzzling how at the moment...

appreciate the reply!

--- Steve K9ZW via SPOT BBS

--- Mystic BBS v1.12 A49 2024/05/29 (Raspberry Pi/32)
* Origin: SPOT BBS / k9zw (1:154/154)
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: Re: src/sbbs3/sbbsecho.c
By: k9zw to Digital Man on Tue Feb 04 2025 05:48 pm

source code repository activity (changes to the Synchronet source,

Alas my system merged this in another echo... puzzling how at the moment...

appreciate the reply!

put your data files in their own sub directory for each msg network you have. ---
þ Synchronet þ ::: BBSES.info - free BBS services :::

MRO wrote to k9zw <=-

source code repository activity (changes to the Synchronet source,

Alas my system merged this in another echo... puzzling how at the moment... appreciate the reply!

put your data files in their own sub directory for each msg network you have.

That isn't necessary and certainly is not the default way.



... He does the work of 3 Men...Moe, Larry & Curly
--- MultiMail/Linux v0.52
þ Synchronet þ Palantir BBS * palantirbbs.ddns.net * Pensacola, FL

Re: Re: src/sbbs3/sbbsecho.c
By: MRO to k9zw on Tue Feb 04 2025 06:04 pm

Alas my system merged this in another echo... puzzling how at the moment...

appreciate the reply!

put your data files in their own sub directory for each msg network you have.

I think it may be the internal sub-board code that matters, not really where the files are stored. The internal sub-board codes need to be unique. If 2 sub-boards share the same internal code, then I'm sure that would cause messages to get duplicated in both sub-boards. But it also doesn't hurt to have the files in separate directories.

Nightfox

---
þ Synchronet þ Digital Distortion: digitaldistortionbbs.com

Re: Re: src/sbbs3/sbbsecho.c
By: Nightfox to MRO on Tue Feb 04 2025 05:28 pm

Re: Re: src/sbbs3/sbbsecho.c
By: MRO to k9zw on Tue Feb 04 2025 06:04 pm

Alas my system merged this in another echo... puzzling how at the moment...

appreciate the reply!

put your data files in their own sub directory for each msg network you have.

I think it may be the internal sub-board code that matters, not really where the files are stored. The internal sub-board codes need to be unique. If 2 sub-boards share the same internal code, then I'm sure that would cause messages to get duplicated in both sub-boards. But it also doesn't hurt to have the files in separate directories.

In this case, the system with the issue is not a Synchronet system, so I don't know if "internal codes" apply. :-)
--
digital man (rob)

Steven Wright quote #7:
A clear conscience is usually the sign of a bad memory.
Norco, CA WX: 54.0øF, 78.0% humidity, 3 mph WNW wind, 0.00 inches rain/24hrs ---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: Re: src/sbbs3/sbbsecho.c
By: Digital Man to Nightfox on Tue Feb 04 2025 08:00 pm

In this case, the system with the issue is not a Synchronet system, so I don't know if "internal codes" apply. :-)

Ah, I didn't see (or notice) it's not a Synchronet system. :)

Nightfox

---
þ Synchronet þ Digital Distortion: digitaldistortionbbs.com

https://gitlab.synchro.net/main/sbbs/-/commit/3ff043da84462d6cf5db9a64
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Log warning-level message when we can't auto-add a sub

... because there's no linked-node configured as the uplink for the parent message group.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/d652854faa37cb4cdf507938
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Address some MSVC static analysis warnings

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/fabef9ea90ed2758081eec2a
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Only log one warning per invocation about inability to auto-add sub

Just the first sub that couldn't be auto-added.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/8010070c0bc86aaf8104a144
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Take the configured origin line chars into account when determining charset

and if the message is UTF-8, encode the origin line as UTF-8 too.
If the message is straight ASCII (e.g. the sub-board is configured as ASCII only), convert the configured origin line to ASCII, before appending.

At this time, only ASCII and CP437 encodings of originlines are supported
in Synchronet (imported and exported origin lines can contain UTF-8).

This should address the issue raise by Sergey Dorofeev (2:5020/12000) in the FidoNet UTF-8 echo whereby messages exported from Synchronet systems (presumably using SBBSecho) could contain a mixture of CP437 and UTF-8 encodings (!) when the sysop had CP437 chars in their configured origin line.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/ca0d64e4e73f352dbfcd4f1b
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Eliminate some unnecessary typecasts and parens

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f78d5395969b6a38a4db8adc
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Add typecast to elminate GCC warning

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/6d037195018beb8a946bdebb
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
When netmail is forwarded to an external (netmai/email) address, notify user

Include the appropriate text.dat string (like the mail server does) in
short message sent to user.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/3bcc0d624061d1833c15ecbf
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
If the area file is configured to be blank, don't try to open/read

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/faf0f4d29ca57bdcc0d130c5
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Fix handling of .msg files from IBBS doors.

IBBS doors configured for Binkley style outbound will put the
binkley directives in the subject, expecting them to pass through
to the FLO file.

SBBSEcho v2 and v3 since a3b2f9e2d have stripped the "delete file"
indication ('^') and generated an error, refusing to send messages
with #, ~, -, !, and @.

This changes the behaviour to translate '-' to '^', '!' to '~', and
strip '@', and keep the prefix that was in the .msg file.

This fixes the issue where outbound files from IBBS games configured
for Binkley style outbound would never get deleted.

Note that in this implementation, the prefix overrides the configured truncation value and any "FLAGS KFL" kludge lines.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/377ac0563666ae3852f33cef
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Fix last commit to not include the prefix when validating the filename

Derp.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/aa7a1b6505417cfcdcc8530b
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Previous "fix" actually broke more than it fixed.

I wouldn't call me a real developer.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/3b527199322f25832617f964
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Fix potential buffer overflow in fmsgattr_str()

Pass it 0xffff and it overflows its local (static) string buffer.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/41e2191514f2a45fe862b6b4
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Replace import_netmail() magic constansts with (expanded) IMPORT_* enum values

The only really important values (other than for debug-logging reasons) are
0 (success) and IMPORT_CLOSED (was -2).

One functional change included here: when fmsgtosmsg returned non-zero values, import_netmail() would log the value and still return 0 (success). This will result in more debug-level log msgs when fmsgtosmsg() returns an error value, but that's all.

The logged import_netmail() error numbers *are* changed by this commit.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/d5b59539e7e688f57ce3c43e
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Implement Deuce's suggested fix for importing netmail messages (.msg files)

... for robots.

I thought he said he was importing packets, but in any case, we don't want to be deleting a .msg file destined for a configured robot.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/e7b93ae3f3f8dfb24d450f1c
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Clean up import_netmail()

- No longer use special return value (IMPORT_CLOSED) to indicate the .msg
file was closed. Now we just set the FILE* to NULL if it was closed and
return IMPORT_SUCCESS.
- No longer deletes the .msg file here; expect the caller (main()) to do that. - Update the message header here (e.g. adding "RECEIVED" attribute flag),
when appropriate. Sometimes this was added here, sometimes in the main(),
and in some cases it should not have been added (e.g. for ignored and
filtered netmail messages) but it was anyway.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/5b21df6e401a7b3071c44f8b
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Fix typo in previous commit

Weird that it compiled without warning. I didn't try linking it, so that's why it wasn't caught.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f8a33572e1e6fe5ac9887856
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Remove direct printf() calls from import_netmail()

... direct all output through lprintf() instead.

This insures that the helpful output may always be logged to the sbbsecho.log file and the sysop need not view the stdout to find out why a netmail message was ignored or discarded or otherwise problematic.

It appeared there may have been redundant output to stdout before anyway and trying to keep both the stdout and the log output both helpful and beautified was getting tedius.

Most sysops don't look at the console/stdout of sbbsecho when it runs and we normally expect a sysop to be able to use the sbbsecho.log file to debug any issues (possibly after increasing their log level to DEBUG).

Include the netmail message attributes value (both in hex and verbose form)
in the information logged about an incoming netmail message.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net